frictionlessdata / frictionless-ci

Data management service that brings continuous data validation to tabular data in your repository via Github Action
https://repository.frictionlessdata.io
MIT License
36 stars 12 forks source link

Release stable v1 #6

Closed roll closed 3 years ago

roll commented 3 years ago

Overview

We need to gather feedback for 1-2 month and then release.

gabrielbdornas commented 3 years ago

Hy @roll, one more time, congratulation on this work! I wonder if you could help me with one question about the validation it's been done here. I suspect that the actual validation is only in the data files and not using datapackages.json, am I right?

I'm using a simple dataset as an example (github repo) where locally "frictionless validate data/letters-vowels.csv" and "frictionless validate data/letters-consonants.csv" work just fine but "frictionless validate datapackage.json" fails (purposely), as you can see in the picture below:

Screenshot from 2021-06-24 12-51-22

Despite this "datapackage" error, everything works fine on the GitHub action continuos validation, as you can see below:

Screenshot from 2021-06-24 12-56-18

Am I right that validations against datapackages.json aren't available yet?

roll commented 3 years ago

Hi @gabrielbdornas, and thanks!

Frictionless Repository just passes the validation inquiry to Frictionless Framework so it should be possible to do any validations you can do with the framework.

Here is a configuration docs - https://repository.frictionlessdata.io/docs/configuration

In you case, it should work if you add this configuration file:

.github/frictionless.yaml (note that it's not in the workflows folder it's a new file)

main:
  tasks:
    - source: datapackage.json
roll commented 3 years ago

@gabrielbdornas Since v0.14 it detects data packages automatically using this glob - https://github.com/frictionlessdata/repository/blob/main/lib/config.js#L6

roll commented 3 years ago

DONE in de6d5b0