Open mcarans opened 7 months ago
@roll Just bringing this issue to your attention as I think it will affect anyone reading Excel with frictionless in Python 3.12.
@roll I tested with frictionless 5.17.0 and unfortunately it doesn't fix this issue
Thanks @mcarans!
Yea, I know, I think they found the reason in this thread - https://github.com/Tinche/aiofiles/issues/166
cc @pdelboca
@roll @pdelboca Tested with 5.17.1 and it still fails.
Hi @mcarans, can't reproduce (tried to validate an .xlsx file with python 3.12.6 + frictionless 5.17.1). Could you please provide data and the command to reproduce ? Thanks.
@pierrecamilleri This will reproduce it:
from frictionless import Detector, Dialect
from frictionless.formats import ExcelControl
from frictionless.resources import TableResource
url = "https://raw.githubusercontent.com/OCHA-DAP/hdx-python-utilities/main/tests/fixtures/downloader/test_xlsx_processing.xlsx?a=1"
control = ExcelControl()
control.sheet = "Trend"
control.fill_merged_cells = True
detector = Detector()
detector.field_type = "any"
detector.field_float_numbers = True
detector.field_missing_values = [""]
dialect = Dialect()
dialect.header = True
dialect.header_rows = [7, 8]
dialect.skip_blank_rows = True
resource = TableResource(
path=url,
format="xlsx",
control=control,
detector=detector,
dialect=dialect,
)
resource.open()
Thanks :pray: , I can reproduce
I have found an issue with frictionless with Python 3.12 that doesn't occur with Python 3.11. Here is the trace:
It can be reproduced with: