search

frictionlessdata / goodtables.io

Data validation as a service. Project retired, got to the current one at frictionsless/repository
https://goodtables.io
GNU Affero General Public License v3.0
69 stars 16 forks source link

Add about page #300

Closed vitorbaptista closed 6 years ago

vitorbaptista commented 6 years ago

@jobarratt It would be great if you could review the text on https://github.com/frictionlessdata/goodtables.io/blob/0eeb4b1caa5457bd1202ac75a2e9e28246c1bc3d/frontend/components/About.vue#L17-L87. This is how the page looks like:

About page

Notice the added links to the top right of the page. As this is the first textual page we've got, I had to implement the UI as well.

@roll On a technical side, I extracted the layout of the page in the AppBaseLayout component, similarly to what you've done in the App component. I couldn't inject the components into it directly, as you do in https://github.com/frictionlessdata/goodtables.io/blob/0eeb4b1caa5457bd1202ac75a2e9e28246c1bc3d/frontend/index.html#L36-L41, because there are multiple named scopes (headers and contents), which are used differently depending on the component. The landing page uses both, while the About page just adds to the contents.

There are no tests because the components are static, so the tests would only be like "check if element X is in the page", which feel worthless.

vitorbaptista commented 6 years ago

Thank you all for the reviews! :+1: