frictionlessdata / goodtables.io

Data validation as a service. Project retired, got to the current one at frictionsless/repository
https://goodtables.io
GNU Affero General Public License v3.0
69 stars 16 forks source link

Fix data type of amount field in writing_data_schema.md #318

Closed jdaviscooke closed 6 years ago

jdaviscooke commented 6 years ago

While going through the getting started docs, we copied the schema provided and were getting the error

Provided schema is not valid.

How it could be resolved:

    Update schema descriptor to be a valid descriptor
    If this error should be ignored disable schema checks in goodtables.yml.

The full list of error messages:

    Table Schema error: Descriptor validation error: {'constraints': {'minimum': 0}, 'name': 'amount', 'format': 'default', 'type': 'numeric', 'description': 'Transaction value in Euros'} is not valid under any of the given schemas at "fields/3" in descriptor and at "properties/fields/items/anyOf" in profile

After reviewing the Table Schema documentation it seems that the correct type is number rather than numeric. This updates the documentation so that validation succeeds for the example.

roll commented 6 years ago

@jdaviscooke Thanks!