Closed danfowler closed 7 years ago
@roll @amercader all the errors in rows 2 and 3 are expected due to the way the file is structured. I believe almost all the other errors are due to the lack of support for missingValue
in the stack. There are lots of missing values in this dataset.
[57,20] [non-castable-value] Row 57 has non castable value in column 20 (type: boolean, format: default)
...due to:
line 56, column 19: NO
line 56, column 20: [Not Available]
line 56, column 21: NO
@danfowler
I've added on top of priority both missingValue
cards.
@roll @danfowler don't let the specs block on this. jsontableschema has a list of NULL values. The only blocker is that this list cannot be extended with custom null values.
@pwalsh
But still the easiest way to bring it to goodtables.io
is implement nullValue
on jts level. Other options will take the same time but will be just hacks if I don't miss anything.
@roll so maybe I'm confused. @rufuspollock already pushed missingValue
to the spec: https://github.com/frictionlessdata/specs/blob/gh-pages/json-table-schema/index.md#missing-values
This deals with it on the level of jsontableschema
. What I am saying is that if further changes to the spec have been discussed (and I am not aware of them), then, don't hold on those for this issue, because there is nothing prioritised for v1 of the specs around that.
@pwalsh So we've just misunderstood each other. What I've said to Dan that we need to implement this:
It's not blocked by specs.
Good Tables output now clean. Re missingValues
in "/frictionlessdata/schemas", are we deprecating the "/frictionlessdata/schemas" repo in favor of https://github.com/frictionlessdata/specs/tree/feature/do-it-better/_data/schemas @pwalsh?
I have created a Data Package that defines a schema for metadata.tsv. Here is the output of
goodtables datapackage datapackage.json