Use matryer/is to make tests cleaner

[danielfireman]

I believe using matryer/is will make tests even more readable. Let's see how it goes.

[ThatEric]

Started looking at this, some of the tests have descriptions, but that isn't really supported by matryer/is. Are you okay ripping those dynamic comments out?

[danielfireman]

Hi @ThatEric, the test descriptions that I can remember are used in subtest descriptions. Does that clarify your question? Could you please point to a specific example?

[ThatEric]

Oh I just mean that the description is sometimes placed in the error message and the matryer/is workflow doesn't allow custom errors like that.

Here is an example of the code in question: t.Errorf("[%s] want:%+v got:%+v", d.Desc, d.Field, f)

That d.Desc is in the error message making a custom error message. In matryer/is you would do this: is.Equal("foo", got) // some static message

There is no option for a dynamic error message as far as I can tell. You could sort of fudge it to work like this, but it sort of semi-defeats the purpose of using matryer/is: if d.Field != f { is.NoErr("[%s] want:%+v got:%+v", d.Desc, d.Field, f))) }

[danielfireman]

Got it.

In those cases, it should be a subtest description. For instance:

t.Errorf("[%s] want:%+v got:%+v", d.Desc, d.Field, f)

Should be:

t.Run(d.Desc, func(t *testing.T) {
     is := is.New(t)
     ...
     is.Equal("foo", got)
})

In that way, we keep code simple/readable but have nice error messages.