frictionlessdata / tableschema-go

A Go library for working with Table Schema.
MIT License
46 stars 10 forks source link

Support `Unique` constrain. #63

Closed ajurasz closed 7 years ago

ajurasz commented 7 years ago

This is for #47. In that issue python implementation was mentioned where uniqueness is checked for the field where this constraint is set and also for all PKs - in my implementation I did the same.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 94.169% when pulling ef1839f9ff676f5d5ee2779ae8749ac2c6769be7 on ajurasz:unique_constrain into 95567344519868d295a03c19b2dbfe80b89c01dc on frictionlessdata:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 94.175% when pulling 46e07d0c2ac0e6ab88024418acce11d28c77a222 on ajurasz:unique_constrain into 95567344519868d295a03c19b2dbfe80b89c01dc on frictionlessdata:master.

ajurasz commented 7 years ago

@danielfireman thank you for your effort on making this review. I have addressed all of your comments.