frictionlessdata / tableschema-go

A Go library for working with Table Schema.
MIT License
46 stars 10 forks source link

Added matryer/is to the tests #64

Closed ThatEric closed 7 years ago

ThatEric commented 7 years ago

Sure I'll look at this today. Interesting that Travis CI didn't like this.

danielfireman commented 7 years ago

The job is confused, somehow. It says there is a reference to reflect at line 563, but the reference does not seem to exist in the new version of the file.

Maybe you a new push (re-organize imports in schema_test.go leaving non-stdlib imports at the end would be great) to the branch would trigger a new correct job?

ThatEric commented 7 years ago

Yeah I noticed that too, it's really odd. I redid the imports and it still doesn't like it.

danielfireman commented 7 years ago

Thanks, @ThatEric ! Great stuff!

danielfireman commented 7 years ago

Just pushed 7972782596e63cf408b6d2233a1e726b65a671a4 , which takes care of some few left overs. Now everything is compiling properly.

Tests are looking awesome!