search

frictionlessdata / tableschema-go

A Go library for working with Table Schema.
MIT License
46 stars 10 forks source link

Table name #76

Closed russmack closed 4 years ago

russmack commented 5 years ago

Hi Daniel, here's something else I needed - setting a table name which I could use in output after processing.

This change is Reviewable

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.6%) to 91.806% when pulling 476294b32871a3fde59e3017c9a2583938d7c577 on russmack:table-name into 8f0f802e93a4dcfe999ad178f2d305625580835b on frictionlessdata:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.2%) to 92.599% when pulling 42182c744c467666b9ccb722e0f95ca1f66a8acc on russmack:table-name into 8f0f802e93a4dcfe999ad178f2d305625580835b on frictionlessdata:master.

danielfireman commented 5 years ago

Hi @russmack ! Would you mind sending a little bit more context on your use case?

Asking because of this change adds a field to the Schema which is not part of the Table Schema specification. Thus it is worth to put a little bit more thought on that.

Furthermore, would you mind sending these two last commits (adding tests) as a separate PR? It would be super nice! :smile:

cc/ @roll

russmack commented 5 years ago

Ah right. I used it to build SQL create table statements - func (s *Schema) ToPostgreSQL() string { ...

Separate PR for those last two commits coming up...

danielfireman commented 5 years ago

What you described sounds a lot like Storage/Plugins tfrom tableschema-py.

I won't be able to work on that right now, but I would be super happy to help/guide/discuss (maybe via VC meeting). If that sounds good to you, I believe the best way to start is opening an issue and describing your use case. How does that sound?

russmack commented 5 years ago

I'll have to add that to my todo list for now. I've had a very brief look and will need more time for it.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.