search

frictionlessdata / tableschema-sql-py

Generate SQL tables, load and extract data, based on JSON Table Schema descriptors.
MIT License
61 stars 19 forks source link

Create field's and table's comment ('title' - 'description'). Manage unique constraints #75

Closed pajachiet closed 5 years ago

pajachiet commented 5 years ago

I did not manage to run the test suite.

I added unit test for the new function _get_comment as doctring tests, that can be run with doctest.

roll commented 5 years ago

Sorry for the very late reply. I think it's great.

The problem with tests are lint related:

$ make test
pylama tableschema_sql
tableschema_sql/mapper.py:59:101: E501 line too long (112 > 100 characters) [pep8]
tableschema_sql/mapper.py:287:101: E501 line too long (101 > 100 characters) [pep8]
tableschema_sql/mapper.py:307:1: W391 blank line at end of file [pep8]
tableschema_sql/storage.py:97:101: E501 line too long (103 > 100 characters) [pep8]
tableschema_sql/storage.py:99:101: E501 line too long (105 > 100 characters) [pep8]
make: *** [test] Error 1
pajachiet commented 5 years ago

I corrected line length. I got other errors locally when running tests.