Closed akariv closed 4 years ago
@akariv
Is there is a way to have this sqlite3-pcre
installed via pip? We can't rely on its existence. And I think we need to skip the check
if not available (for sqlite).
Tbh I would skip it either way as it's not natively supported by sqlite. Wdyt?
On Mon, Oct 28, 2019, 15:39 roll notifications@github.com wrote:
@akariv https://github.com/akariv Is there is a way to have this sqlite3-pcre installed via pip? We can't rely on its existence. And I think we need to skip the check if not available.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/frictionlessdata/tableschema-sql-py/pull/85?email_source=notifications&email_token=AACAY5O2FRD7KD7KZCLTGF3QQ3TQDA5CNFSM4JF2DIT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECM4XHI#issuecomment-546950045, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5PRIFDNRVQXJG4GFNDQQ3TQDANCNFSM4JF2DITQ .
@akariv I agree. Let's skip.
Okay, I found a workaround - see the tests code for an example
^ @roll
you made it :smiley:
Overview
Please replace this line with full information about your pull request. Make sure that tests pass before publishing it
Please preserve this line to notify @roll (lead of this repository)