search

frictionlessdata / tableschema-sql-py

Generate SQL tables, load and extract data, based on JSON Table Schema descriptors.
MIT License
60 stars 19 forks source link

Support indexes in sqlite. #90

Closed pwalsh closed 2 years ago

pwalsh commented 2 years ago

Overview

Index field code was available for postgresql only.

Please preserve this line to notify @roll (lead of this repository)

pwalsh commented 2 years ago

@akariv this one requires you to review for me to proceed with it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #90 (4cf869b) into main (a9a7035) will increase coverage by 0.95%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   82.66%   83.61%   +0.95%     
==========================================
  Files           4        4              
  Lines         421      421              
==========================================
+ Hits          348      352       +4     
+ Misses         73       69       -4
Impacted Files Coverage Δ
tableschema_sql/mapper.py 91.30% <100.00%> (+2.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9a7035...4cf869b. Read the comment docs.

pwalsh commented 2 years ago

@akariv ok, I've updated here based on main, and even though I have removed the coveralls connection, the check above is still blocked by coveralls. As far as I see I don't have anywhere else to remove it from. Maybe you have an idea based on what you did for ts-es?

akariv commented 2 years ago

Iirc you need to change it in the protected branches settings