search

frida / frida-node

Frida Node.js bindings
282 stars 66 forks source link

Change session.enumerateRanges to accommodate a scope to allow searching... #4

Closed SomeoneWeird closed 9 years ago

SomeoneWeird commented 9 years ago

... within a module.

If a scope is specified, Module.enumerateRanges is used instead of Process.enumerateRanges, so you can search a range within a module.

session.enumerateRanges('rw-', {
  scope: "libSystem.B.dylib" // etc
});
oleavr commented 9 years ago

One nitpick about the commit message: looks very good, but if possible try to limit the length of the subject line to just 50 chars or less.

SomeoneWeird commented 9 years ago

Done :)

SomeoneWeird commented 9 years ago

Yeah my bad, fixed.

oleavr commented 9 years ago

Looks great! One last thing; could you fix the commit message subject line? (Shorten to 50 chars or less, and remove the full stop at the end)

SomeoneWeird commented 9 years ago

How's that?

oleavr commented 9 years ago

I would say:

Enable enumerateRanges() to search within a module

And reflow the lines of the body so they go to 72 columns, that would be
awesome! Lorem ipsum.
SomeoneWeird commented 9 years ago

How about now? :)

oleavr commented 9 years ago

Awesome! :)