frida / frida-rust

Frida Rust bindings
Other
176 stars 46 forks source link

Fix unsound Transformer::from_callback API #103

Closed Mrmaxmeier closed 1 year ago

Mrmaxmeier commented 1 year ago

This makes sure that the callback passed to the Transformer outlives the Transformer object itself. Previously, the implicit bound was only for the lifetime of the init call, and thus allowed creating callback closures that use dangling captured references.

Note that this breaks the API interface. Should I include a version bump to v0.13.0?

Fixes #102.

meme commented 1 year ago

Thanks!