frida / frida-rust

Frida Rust bindings
Other
176 stars 46 forks source link

Add a couple of useful features to Device #110

Closed fabianfreyer closed 10 months ago

fabianfreyer commented 12 months ago

I needed these things, so here they are. If you'd rather have self-contained PR's, happy to do that too,.

Would be really cool to get these into a 0.14 release!

fabianfreyer commented 12 months ago

46d9dda will probably conflict with #108, so whichever gets merged last should use the other's DeviceType struct.

meme commented 12 months ago

LGTM. Please look into the Windows build failures. Thanks.

fabianfreyer commented 12 months ago

@meme done, and rebased.

meme commented 11 months ago

Please resolve the conflicts so I can merge. Thanks again, apologies for the delay.

fabianfreyer commented 11 months ago

Please resolve the conflicts so I can merge. Thanks again, apologies for the delay.

done. I've merged my DeviceType implementations into @csnewman's (#108), in an AFACT backwards-compatible way.

meme commented 11 months ago

Looks like checks are still failing.

fabianfreyer commented 11 months ago

Oh, looks like I didn't run rustfmt on each commit. Fixed that, sorry!

fabianfreyer commented 10 months ago

@meme ping?

fabianfreyer commented 10 months ago

Thanks!