fix: compilation on nightly

frida / frida-rust

Frida Rust bindings

Other

188 stars 53 forks source link

fix: compilation on nightly #130

Closed amaanq closed 7 months ago

amaanq commented 8 months ago

It does not compile on nightly (1.79.0-nightly (805813650 2024-03-31) to be exact) due to the #![deny(warnings)] attribute and redundant imports becoming a warning. Thanks!

s1341 commented 8 months ago

Looks like it needs a little work. Please fix CI and then I will land.

amaanq commented 8 months ago

Ah I see, the cfg for those imports wasn't correct, they're needed in the no_std case (when none of the features are enabled, not just module-names)

Should be good now I think, sorry about that

s1341 commented 8 months ago

I think you missed one....

amaanq commented 8 months ago

oops, fixed

amaanq commented 7 months ago

Hey @s1341 gentle reminder in case you're busy/forgot about this pr :)

s1341 commented 7 months ago

Thanks for your contribution!

amaanq commented 7 months ago

thanks!