search

frida / frida-rust

Frida Rust bindings
Other
185 stars 52 forks source link

Add support for stalker-observer #75

Closed WorksButNotTested closed 1 year ago

meme commented 1 year ago

LGTM. Please address the lints from CI. Thanks.

WorksButNotTested commented 1 year ago

Thanks for the quick feedback. I don’t think the lints relate to any files I have changed, so not sure how they’ve cropped up? Happy to tackle them, but just wary of breaking something without understanding what’s going on.

WorksButNotTested commented 1 year ago

Just ran a cargo clippy --fix -F auto-download and everything seems happy?!

WorksButNotTested commented 1 year ago

Seems that the as statements are necessary for x86. But are redundant on x64. Given how many there are, it would introduce a large number of conditional #[cfg(...)] blocks? What do you think is the best approach?

meme commented 1 year ago

Ah. In that case, it's noise. Please disable that lint for x64 for that file.

WorksButNotTested commented 1 year ago

Hopefully this should sort it. There is the converse issue for x86 where clippy complains about u32->u32 casts. So I disabled the rule for both architectures.

WorksButNotTested commented 1 year ago

Awesome, thanks for the merge.