search

frida / frida-rust

Frida Rust bindings
Other
176 stars 46 forks source link

remove external capstone dependency, use frida's #99

Closed aviramha closed 1 year ago

aviramha commented 1 year ago

Closes #81

aviramha commented 1 year ago

@meme would love your review :)

meme commented 1 year ago

I don't object to these changes, but the problem is for more performance-intensive programs like fuzzers, they need a separate decode stage. The other option is to have a Frida fork of Capstone, but that has its own challenges (especially since Frida's Capstone and the regular Capstone crate can't co-exist).

So, if @domenukk and @s1341 don't object to these changes (specially the potential performance impact), then that's OK with me - we can shed the dependency and the complexity.

s1341 commented 1 year ago

I think we can live with this. So far as I know, we have been until now. My only hesitation is that tools using frida-gum and capstone-rs, like LibAFL does, will need to re-decode the instructions during stalking.

meme commented 1 year ago

Let's roll with this. Thank you.