search

frida / frida-tools

Frida CLI tools
Other
348 stars 97 forks source link

Populate <state> global variable with user data before beginning trace session #29

Closed mosherubin closed 4 years ago

mosherubin commented 4 years ago

The ability for the user to pass a session-specific string on the command line and have it stored in the global variable before starting the trace will allow more dynamic control of handler behaviour. This data-driven, rather than code-driven, model enables the user to modify what a handler will do without having to modify its code on a continual basis.

oleavr commented 4 years ago

Implemented a slightly different solution in de8e34759badf7622521c20ff12e9720203473ad, which is consistent with our REPL. Thanks a lot for digging into this! :raised_hands:

mosherubin commented 4 years ago

Oleavr,

A big thank you for making the last few steps to close PRs 27-29 on your own. I salute and commend your collaborative style: you prefer that a PR submitter be guided and taught to make the correct changes on his/her own. In my case, the back-and-forth on these last PR steps would have prevented getting the features out in the immediate future.

I have learned so much about Python and related topics from you, and I thank you for that.

It has been a pleasure working with you on Frida-related PRs. One hears horror stories of other Open Source projects regarding the behavior of the primary maintainers to submitters. If anyone is reading this, working with you on Frida and Frida-Tools has been a most wonderful experience for me -- I highly recommend collaborating with Oleavr on Frida (you will thank me for this advice!). In fact, it has whetted my appetite for more, so this will not be the last you've heard from me! :-)

My next frida-tools-related tasks is to update the documentation with these last three PR new options (27-29), so stay tuned.

Wishing you a Happy New Year, and looking forward to more collaborations in the future,

Moshe

oleavr commented 4 years ago

@mosherubin Thank you for your kind and generous words, and for having patience with my excessive pedantry/OCD! :blush: It was also a pleasure from my side, so am very much looking forward to future collaborations as well!

Happy New Year! :tada: