friday-ai / friday

Friday is your open-source home automation assistant.
MIT License
1 stars 1 forks source link

Plugin test investigation #115

Closed MathieuAndrade closed 11 months ago

MathieuAndrade commented 11 months ago

This pull request is only dedicated to investigate on "plugin.stop.test". This test works locally and works on docker environnemnt (locally also) but not on github action. So we investigate here to understand why this test always fails in github action environnement.

All commits are for investigation purpose, none of them has vocation to go in master branch

github-actions[bot] commented 11 months ago

Unit Test Results

    1 files  ±  0  169 suites  +14   2m 5s :stopwatch: + 1m 44s 556 tests +39  554 :heavy_check_mark: +37  0 :zzz: ±0  2 :x: +2  557 runs  +39  555 :heavy_check_mark: +37  0 :zzz: ±0  2 :x: +2 

For more details on these failures, see this check.

Results for commit 535c9a9a. ± Comparison against base commit 98fc2fd6.

This pull request removes 5 and adds 44 tests. Note that renamed tests count towards both. ``` admin should have access to delete a plugin ‑ DELETE /api/v1/plugin/:id admin should have access to delete a plugin guest should't have access to delete a plugin ‑ DELETE /api/v1/plugin/:id guest should't have access to delete a plugin habitant should't have access to delete a plugin ‑ DELETE /api/v1/plugin/:id habitant should't have access to delete a plugin should delete a plugin ‑ DELETE /api/v1/plugin/:id should delete a plugin should not found plugin to delete ‑ DELETE /api/v1/plugin/:id should not found plugin to delete ``` ``` admin should have access to install a plugin ‑ POST /api/v1/plugin admin should have access to install a plugin admin should have access to restart a plugin ‑ PATCH /api/v1/plugin/restart/:id admin should have access to restart a plugin admin should have access to restart all plugins of a satellite ‑ PATCH /api/v1/satellite/restart/plugins/:id admin should have access to restart all plugins of a satellite admin should have access to stop a plugin ‑ PATCH /api/v1/plugin/stop/:id admin should have access to stop a plugin admin should have access to stop all plugins of a satellite ‑ PATCH /api/v1/satellite/stop/plugins/:id admin should have access to stop all plugins of a satellite admin should have access to uninstall a plugin ‑ DELETE /api/v1/plugin/:id admin should have access to uninstall a plugin guest should't have access to install a plugin ‑ POST /api/v1/plugin guest should't have access to install a plugin guest should't have access to restart a plugin ‑ PATCH /api/v1/plugin/restart/:id guest should't have access to restart a plugin guest should't have access to restart all plugins of a satellite ‑ PATCH /api/v1/satellite/restart/plugins/:id guest should't have access to restart all plugins of a satellite guest should't have access to stop a plugin ‑ PATCH /api/v1/plugin/stop/:id guest should't have access to stop a plugin … ```
github-actions[bot] commented 11 months ago

Unit Test Results

1 files  ±    0  2 suites   - 153   10s :stopwatch: -11s 4 tests  - 513  4 :heavy_check_mark:  - 513  0 :zzz: ±0  0 :x: ±0  4 runs   - 514  4 :heavy_check_mark:  - 514  0 :zzz: ±0  0 :x: ±0 

Results for commit 8099be3d. ± Comparison against base commit 98fc2fd6.

This pull request removes 515 and adds 2 tests. Note that renamed tests count towards both. ``` admin should have access to delete a plugin ‑ DELETE /api/v1/plugin/:id admin should have access to delete a plugin admin should have access to update a plugin ‑ PATCH /api/v1/plugin/:id admin should have access to update a plugin admin should have to create a user ‑ POST /api/v1/user admin should have to create a user admin should have to delete a user ‑ DELETE /api/v1/user/:id admin should have to delete a user admin should have to login an user ‑ POST /api/v1/user/login admin should have to login an user admin should have to read a plugin with full scope ‑ GET /api/v1/plugin/:id admin should have to read a plugin with full scope admin should have to read a variable value ‑ GET /api/v1/variable/:key admin should have to read a variable value admin should have to read all plugins with full scope ‑ GET /api/v1/plugin admin should have to read all plugins with full scope admin should have to update a user ‑ PATCH /api/v1/user/:id admin should have to update a user admin should't have to create a variable ‑ POST /api/v1/variable admin should't have to create a variable … ``` ``` should not stop a plugin already stopped ‑ Plugin.stop should not stop a plugin already stopped should not stop a plugin with wrong docker id ‑ Plugin.stop should not stop a plugin with wrong docker id ```
codecov[bot] commented 11 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Files Coverage Δ
apps/server/src/api/routes/v1/plugin.ts 100.00% <100.00%> (+10.00%) :arrow_up:
apps/server/src/api/routes/v1/satellite.ts 87.87% <100.00%> (+2.69%) :arrow_up:
apps/server/src/core/plugin/plugin.install.ts 87.50% <100.00%> (+1.13%) :arrow_up:
apps/server/src/core/plugin/plugin.restart.ts 100.00% <100.00%> (ø)
apps/server/src/core/plugin/plugin.stop.ts 100.00% <100.00%> (ø)
apps/server/src/core/plugin/plugin.ts 100.00% <100.00%> (ø)
apps/server/src/core/plugin/plugin.uninstall.ts 100.00% <100.00%> (ø)
.../src/core/satellite/satellite.restartAllPlugins.ts 100.00% <100.00%> (ø)
...ver/src/core/satellite/satellite.stopAllPlugins.ts 100.00% <100.00%> (ø)
apps/server/src/core/satellite/satellite.ts 100.00% <100.00%> (ø)
... and 2 more

:loudspeaker: Thoughts on this report? Let us know!.

github-actions[bot] commented 11 months ago

Unit Test Results

  1 files  ±    0  20 suites   - 135   47s :stopwatch: +26s 78 tests  - 439  77 :heavy_check_mark:  - 440  0 :zzz: ±0  1 :x: +1  78 runs   - 440  77 :heavy_check_mark:  - 441  0 :zzz: ±0  1 :x: +1 

For more details on these failures, see this check.

Results for commit cc6b1d29. ± Comparison against base commit 98fc2fd6.

This pull request removes 464 and adds 25 tests. Note that renamed tests count towards both. ``` admin should have access to delete a plugin ‑ DELETE /api/v1/plugin/:id admin should have access to delete a plugin admin should have to create a user ‑ POST /api/v1/user admin should have to create a user admin should have to delete a user ‑ DELETE /api/v1/user/:id admin should have to delete a user admin should have to login an user ‑ POST /api/v1/user/login admin should have to login an user admin should have to read a variable value ‑ GET /api/v1/variable/:key admin should have to read a variable value admin should have to update a user ‑ PATCH /api/v1/user/:id admin should have to update a user admin should't have to create a variable ‑ POST /api/v1/variable admin should't have to create a variable admin should't have to delete a variable ‑ DELETE /api/v1/variable/:id admin should't have to delete a variable admin should't have to update a variable with a id ‑ PATCH /api/v1/variable/:id admin should't have to update a variable with a id guest should have to login an user ‑ POST /api/v1/user/login guest should have to login an user … ``` ``` admin should have access to install a plugin ‑ POST /api/v1/plugin admin should have access to install a plugin admin should have access to restart a plugin ‑ PATCH /api/v1/plugin/restart/:id admin should have access to restart a plugin admin should have access to uninstall a plugin ‑ DELETE /api/v1/plugin/:id admin should have access to uninstall a plugin guest should't have access to install a plugin ‑ POST /api/v1/plugin guest should't have access to install a plugin guest should't have access to restart a plugin ‑ PATCH /api/v1/plugin/restart/:id guest should't have access to restart a plugin guest should't have access to uninstall a plugin ‑ DELETE /api/v1/plugin/:id guest should't have access to uninstall a plugin habitant should't have access to install a plugin ‑ POST /api/v1/plugin habitant should't have access to install a plugin habitant should't have access to restart a plugin ‑ PATCH /api/v1/plugin/restart/:id habitant should't have access to restart a plugin habitant should't have access to uninstall a plugin ‑ DELETE /api/v1/plugin/:id habitant should't have access to uninstall a plugin should install a plugin ‑ POST /api/v1/plugin should install a plugin … ```
github-actions[bot] commented 11 months ago

Unit Test Results

    1 files  ±  0  169 suites  +14   2m 3s :stopwatch: + 1m 42s 556 tests +39  554 :heavy_check_mark: +37  0 :zzz: ±0  2 :x: +2  557 runs  +39  555 :heavy_check_mark: +37  0 :zzz: ±0  2 :x: +2 

For more details on these failures, see this check.

Results for commit 1af0f43a. ± Comparison against base commit 98fc2fd6.

This pull request removes 5 and adds 44 tests. Note that renamed tests count towards both. ``` admin should have access to delete a plugin ‑ DELETE /api/v1/plugin/:id admin should have access to delete a plugin guest should't have access to delete a plugin ‑ DELETE /api/v1/plugin/:id guest should't have access to delete a plugin habitant should't have access to delete a plugin ‑ DELETE /api/v1/plugin/:id habitant should't have access to delete a plugin should delete a plugin ‑ DELETE /api/v1/plugin/:id should delete a plugin should not found plugin to delete ‑ DELETE /api/v1/plugin/:id should not found plugin to delete ``` ``` "after all" hook: after for "should not found satellite" ‑ Satellite.stopAllPlugins "after all" hook: after for "should not found satellite" "before all" hook for "should stop all plugins of a satellite" ‑ Satellite.stopAllPlugins "before all" hook for "should stop all plugins of a satellite" admin should have access to install a plugin ‑ POST /api/v1/plugin admin should have access to install a plugin admin should have access to restart a plugin ‑ PATCH /api/v1/plugin/restart/:id admin should have access to restart a plugin admin should have access to restart all plugins of a satellite ‑ PATCH /api/v1/satellite/restart/plugins/:id admin should have access to restart all plugins of a satellite admin should have access to stop a plugin ‑ PATCH /api/v1/plugin/stop/:id admin should have access to stop a plugin admin should have access to stop all plugins of a satellite ‑ PATCH /api/v1/satellite/stop/plugins/:id admin should have access to stop all plugins of a satellite admin should have access to uninstall a plugin ‑ DELETE /api/v1/plugin/:id admin should have access to uninstall a plugin guest should't have access to install a plugin ‑ POST /api/v1/plugin guest should't have access to install a plugin guest should't have access to restart a plugin ‑ PATCH /api/v1/plugin/restart/:id guest should't have access to restart a plugin … ```
github-actions[bot] commented 11 months ago

Unit Test Results

    1 files  ±  0  169 suites  +14   2m 7s :stopwatch: + 1m 46s 556 tests +39  556 :heavy_check_mark: +39  0 :zzz: ±0  0 :x: ±0  557 runs  +39  557 :heavy_check_mark: +39  0 :zzz: ±0  0 :x: ±0 

Results for commit 1af0f43a. ± Comparison against base commit 98fc2fd6.

This pull request removes 5 and adds 44 tests. Note that renamed tests count towards both. ``` admin should have access to delete a plugin ‑ DELETE /api/v1/plugin/:id admin should have access to delete a plugin guest should't have access to delete a plugin ‑ DELETE /api/v1/plugin/:id guest should't have access to delete a plugin habitant should't have access to delete a plugin ‑ DELETE /api/v1/plugin/:id habitant should't have access to delete a plugin should delete a plugin ‑ DELETE /api/v1/plugin/:id should delete a plugin should not found plugin to delete ‑ DELETE /api/v1/plugin/:id should not found plugin to delete ``` ``` admin should have access to install a plugin ‑ POST /api/v1/plugin admin should have access to install a plugin admin should have access to restart a plugin ‑ PATCH /api/v1/plugin/restart/:id admin should have access to restart a plugin admin should have access to restart all plugins of a satellite ‑ PATCH /api/v1/satellite/restart/plugins/:id admin should have access to restart all plugins of a satellite admin should have access to stop a plugin ‑ PATCH /api/v1/plugin/stop/:id admin should have access to stop a plugin admin should have access to stop all plugins of a satellite ‑ PATCH /api/v1/satellite/stop/plugins/:id admin should have access to stop all plugins of a satellite admin should have access to uninstall a plugin ‑ DELETE /api/v1/plugin/:id admin should have access to uninstall a plugin guest should't have access to install a plugin ‑ POST /api/v1/plugin guest should't have access to install a plugin guest should't have access to restart a plugin ‑ PATCH /api/v1/plugin/restart/:id guest should't have access to restart a plugin guest should't have access to restart all plugins of a satellite ‑ PATCH /api/v1/satellite/restart/plugins/:id guest should't have access to restart all plugins of a satellite guest should't have access to stop a plugin ‑ PATCH /api/v1/plugin/stop/:id guest should't have access to stop a plugin … ```
MathieuAndrade commented 11 months ago

Thanks for your patience 😄