search

friday-ai / friday

Friday is your open-source home automation assistant.
MIT License
1 stars 1 forks source link

Bump ws from 7.4.4 to 7.4.6 in /server #51

Closed dependabot[bot] closed 2 years ago

dependabot[bot] commented 3 years ago

Bumps ws from 7.4.4 to 7.4.6.

Release notes

Sourced from ws's releases.

7.4.6

Bug fixes

  • Fixed a ReDoS vulnerability (00c425ec).

A specially crafted value of the Sec-Websocket-Protocol header could be used to significantly slow down a ws server.

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();

value.trim().split(/ *, */);


const end = process.hrtime.bigint();


console.log('length = %d, time = %f ns', length, end - start);
}

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

7.4.5

Bug fixes

  • UTF-8 validation is now done even if utf-8-validate is not installed (23ba6b29).
  • Fixed an edge case where websocket.close() and websocket.terminate() did not close the connection (67e25ff5).
Commits
  • f5297f7 [dist] 7.4.6
  • 00c425e [security] Fix ReDoS vulnerability
  • 990306d [lint] Fix prettier error
  • 32e3a84 [security] Remove reference to Node Security Project
  • 8c914d1 [minor] Fix nits
  • fc7e27d [ci] Test on node 16
  • 587c201 [ci] Do not test on node 15
  • f672710 [dist] 7.4.5
  • 67e25ff [fix] Fix case where abortHandshake() does not close the connection
  • 23ba6b2 [fix] Make UTF-8 validation work even if utf-8-validate is not installed
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/friday-ai/friday/network/alerts).
codecov[bot] commented 3 years ago

Codecov Report

Merging #51 (c322aec) into master (5bbb84d) will increase coverage by 0.67%. The diff coverage is 95.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   93.69%   94.37%   +0.67%     
==========================================
  Files          99      139      +40     
  Lines        1206     1528     +322     
  Branches       91      106      +15     
==========================================
+ Hits         1130     1442     +312     
- Misses         60       68       +8     
- Partials       16       18       +2
Flag Coverage Δ
unittests 94.37% <95.04%> (+0.67%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/src/api/routes/v1/device.ts 100.00% <ø> (ø)
server/src/core/device/device.create.ts 100.00% <ø> (ø)
...rver/src/core/device/features/common/common.url.ts 71.42% <71.42%> (ø)
...r/src/core/device/features/media/media.playlist.ts 71.42% <71.42%> (ø)
.../device/features/thermostat/thermostat.planning.ts 71.42% <71.42%> (ø)
...rc/core/device/features/media/media.launch-game.ts 75.00% <75.00%> (ø)
...r/src/core/device/features/media/media.metadata.ts 75.00% <75.00%> (ø)
...rc/core/device/features/media/media.push-button.ts 75.00% <75.00%> (ø)
...rver/src/core/device/features/media/media.title.ts 75.00% <75.00%> (ø)
server/src/core/device/features/light/light.hue.ts 85.29% <85.29%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5445eaa...c322aec. Read the comment docs.

dependabot[bot] commented 2 years ago

Looks like ws is up-to-date now, so this is no longer needed.