fridays / next-routes

Universal dynamic routes for Next.js
MIT License
2.47k stars 230 forks source link

use typescript it's show error TS1192: Module '"http"' has no default export. #157

Closed polo13999 closed 6 years ago

polo13999 commented 6 years ago

when I upgrade version, it has the error message

node_modules/next-routes/typings/next-routes.d.ts(1,8): error TS1192: Module '"http"' has no default export.

fridays commented 6 years ago

ping @disintegrator can you help?

disintegrator commented 6 years ago

Yep will do

On Sat, 24 Mar 2018 at 08:35, fridays notifications@github.com wrote:

ping @disintegrator https://github.com/disintegrator can you help?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fridays/next-routes/issues/157#issuecomment-375853536, or mute the thread https://github.com/notifications/unsubscribe-auth/AApalHLg-HZxFfh-bxLbczVtiL2R-QFOks5thfdcgaJpZM4S5k5t .

disintegrator commented 6 years ago

@polo13999 ~are you able to try again with "esModuleInterop": true in your tsconfig? next.js typings require this setting from us now...~

disintegrator commented 6 years ago

@polo13999, @fridays i'm still investigating this but will need a little more time so far it seems esModuleInterop needs to be false in order to consume nextjs's typings. This is the test config we use:

{
  "compilerOptions": {
    "target": "esnext",
    "module": "esnext",
    "noEmit": true,
    "jsx": "react",
    "strict": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "noImplicitReturns": true,
    "noFallthroughCasesInSwitch": true,
    "moduleResolution": "node"
  }
}

It may be a case of mentioning something about using with typescript in the README. I'll try and find a final solution later today

disintegrator commented 6 years ago

@polo13999 we’ve attempted to address this issue in #158 can you please update to 1.4.1 and try again?