Fixes type definition for default export

fridays / next-routes

Universal dynamic routes for Next.js

MIT License

2.47k stars 230 forks source link

Fixes type definition for default export #218

Closed JFranciscoRader closed 1 year ago

JFranciscoRader commented 6 years ago

The definition was different from the actual code so I changed it to be the same, a function. This change fixes the usage in typescript.

coveralls commented 6 years ago

Coverage decreased (-0.3%) to 94.515% when pulling c81dd666ee0a759d158017758ad566002c2aea17 on JFranciscoRader:types/fix-default-export-definition into 08e8bbeaa76c5ec194abea388a193bedac7f35fc on fridays:master.

ldiego08 commented 6 years ago

I really, REALLY need this. 🙏

JFranciscoRader commented 6 years ago

@ldiego08 I'll fix the coverage here, meanwhile you can use my fork, if you point to master in there, It exposes the already built library with this fix.

filidorwiese commented 5 years ago

Right, I thought I was going nuts. This fixes typescript support for me as well. Thanks!