search

fridays / next-routes

Universal dynamic routes for Next.js
MIT License
2.47k stars 230 forks source link

Add return statement to getRequestHandler middleware #230

Closed dmytro-lymarenko closed 1 year ago

dmytro-lymarenko commented 6 years ago

This return statement should be there as that functions return promises and getRequestHandler just breaks promise chain.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 94.468% when pulling 2faf867d2d72c7ef6a05a5c41a673f911cab4bc5 on dmytro-lymarenko:master into 08e8bbeaa76c5ec194abea388a193bedac7f35fc on fridays:master.

fridays commented 6 years ago

Thanks, not sure I understand because the standard Node.js (and Express) request handler is just a function callback, no promise.

dmytro-lymarenko commented 6 years ago

@fridays, this is for koa routes. I'm using next js with koa as a custom server and I need to wait for it.

dmytro-lymarenko commented 5 years ago

How should I write tests so its coverage passes?