search

fridays / next-routes

Universal dynamic routes for Next.js
MIT License
2.47k stars 230 forks source link

Add a disableDefaultHandler option to the route... #235

Closed llexical closed 1 year ago

llexical commented 6 years ago

handler and add return to handler responses.

Disable default handler option will allow people who need to handle extra express routing seperately. For example I need to handle a default Angular app fallback, also sitemap stuff. This does not affect link in anyway as it is outside of the next app.

Also add disable default handler code example in how to use, with how to do NextJS asset routing without it taking over your whole server so you can add a default route.

WARNING: Example may be subject to change if NextJS change their routing structure.

Note: Not 100% sure on naming, happy to change if anyone comes up with a better name!

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 94.606% when pulling 5357daa50688a5125365b4675a5e6499e76b1dc3 on llexical:master into 08e8bbeaa76c5ec194abea388a193bedac7f35fc on fridays:master.

llexical commented 6 years ago

Not entirely sure why the coverage is failing as when I pulled it down and ran the tests it had 94.57% coverage and it now has 94.62%.