fridays / next-routes

Universal dynamic routes for Next.js
MIT License
2.47k stars 230 forks source link

replace includes with indexOf #33

Closed davidnguyen11 closed 7 years ago

davidnguyen11 commented 7 years ago

Hi!

About this issue: https://github.com/fridays/next-routes/issues/32

As my investigation at case When using Router.pushRoute('index', params) from link above. Root cause:

Solution:

albinekb commented 7 years ago

Don't think this is the correct way to solve this, better is for @nndung179 to add a polyfill/transpile this? Otherwise you should add tests for checking that you're not using ES6 features

google search for stats of ios versions: https://hwstats.unity3d.com/mobile/os-ios.html, iOS 8.4 is ~2%.

when https://github.com/zeit/next.js/pull/1808 lands you can just add a .babelrc and configure browser targets 👌

HaNdTriX commented 7 years ago

Thanks a lot for contributing! Nevertheless we already have spotted this issue in https://github.com/fridays/next-routes/pull/37. Since you also need to polyfill Array.find I am closing this issue in favor of #37.