Shim ES6 methods for IE11 close #27

fridays / next-routes

Universal dynamic routes for Next.js

MIT License

2.47k stars 230 forks source link

Shim ES6 methods for IE11 close #27 #37

Closed HaNdTriX closed 7 years ago

HaNdTriX commented 7 years ago

To solve problems in IE 11 and make this lib easy to use we need to shim ES6 methods:

[x] Object.assign - polyfilled by next.js
[x] Array.find - ponyfilled by this PR
[x] Array.includes - ponyfilled by this PR

I am not a big fan of this because I believe it is the job of preset-env to add such polyfills. Nevertheless right now it is pretty complex to configure it via next.config.js

What do you think about this PR @fridays?

Status: ⚠️ Not tested

sfrieson-tm commented 7 years ago

Thanks @HaNdTriX for taking a stab at this. I was contemplating doing the same today.

fridays commented 7 years ago

Many thanks @HaNdTriX ! It's probably the best way to solve this for now. I'll publish in a moment.

fridays commented 7 years ago

It's now there in 1.0.25

sfrieson-tm commented 7 years ago

I'm testing and seeming to have issues with Object.assign. Do you have any suggestions on how to definitively test? I'm not seeing errors from find or includes.