non-dynamic routes aren't handled

[sedubois]

Here's my project which I just upgraded to use next-routes 🎉

https://github.com/relatenow/relate

Unfortunately I was a bit fast, it looks like non-dynamic routes (like /about) aren't handled properly, they give a not found page when reloading from server (but work client-side). Did I miss something in the configuration or would this be a bug?

[fridays]

Hey, I can't find next-routes in that project, can you post the configuration here?

If a path can't be matched by next-routes, it simply passes the request to the default handler, so it should work fine.

[sedubois]

Sorry forgot to git push 😄 it's there now.

[fridays]

Ah that's because you use a catchall route, it routes everything to the profile page.

If you want some paths not handled by it, add them before:

routes.add('about', '/about');
routes.add('profile', '/:slug');

[sedubois]

Hmm yes that's unavoidable I guess. Thanks 🙏

[sedubois]

Could the API be maybe simplified to accept routes.add('about')? And the second argument pathname would be derived from the first if not provided.

[sedubois]

And even better, accepting an array for the first argument:

routes.add([
  'about',
  'discover'
]);

or routes.addAll

[fridays]

Could the API be maybe simplified to accept routes.add('about')

Good idea! 👍

You can now do that when you npm update

Also you can do chaining:

routes
  .add('about')
  .add('discover')
  .add('blog', '/:slug')

[sedubois]

Thanks, works 👍