search

fridgerator / PyNode

Node - Python Interop
154 stars 14 forks source link

node-gyp fails on node 12.5.0; node-gyp 5.0.3 #15

Closed rikvermeer closed 5 years ago

rikvermeer commented 5 years ago

Hii, I wanna try your library, it seems interesting. However I got this error when building.

../src/main.cpp:308:61: error: too few arguments to function call, single argument 'context' was not specified Nan::New(OpenFile)->GetFunction());


/Users/rikvermeer/Library/Caches/node-gyp/12.5.0/include/node/v8.h:5948:3: note: 'GetFunction' declared here
  V8_WARN_UNUSED_RESULT MaybeLocal<Function> GetFunction(
fridgerator commented 5 years ago

I havent tested on node 12, looks like the node api changed. I'll have to look into it.

Node 10.16.3 is working.

fridgerator commented 5 years ago

@rikvermeer Should be working in node 12 now with version 0.3.4 :+1:

rikvermeer commented 5 years ago

Will try!! Thanks :D

I came here through this article btw: https://thecodinginterface.com/blog/bridging-nodejs-and-python-with-pynode/

Maybe mention there that it works for node 12 now too?

rikvermeer commented 5 years ago

I've tested but got an error. I've filed it under:

https://github.com/fridgerator/PyNode/issues/17