search

fridgerator / PyNode

Node - Python Interop
154 stars 14 forks source link

Dockerizing PyNode apps #32

Open ozanerturk opened 3 years ago

ozanerturk commented 3 years ago

Thanks a lot for this library, it is amazingly fast! Just awesome.

It is hard to find a docker image able to run pynode apps so i made one, https://github.com/ozanerturk/pynode-docker-example Firstly I wanted to add into this repo by PR but not sure where to put it. If you like the idea we could discuss how to add it into this repository.

Bests,

fridgerator commented 3 years ago

Glad to hear that you like the library.

Yes I like the idea of adding Docker to the repository, I use Docker whenever I can. Perhaps an 'examples' or 'docker' folder with a simple example? Or did you have another idea?

ozanerturk commented 3 years ago

Great. Both actually. Docker folder will contain a dockerfile and endpoint.sh script etc which builds image for pynode. Let's start with a particular node.js and python version later we could add a version matrix and proper workflows to update docker releases 'example' folder would includes an example docker app which based on "pynode" docker image.

If these are ok I can start with these and create a pull requests then we can proceed on there. A _------- And friend, this lib deserves more reputation that it is. It is just amazing and fast!! Traditional ways are hard to manage(child processes) and have some speed drawbacks. Thank you for that again.

fridgerator commented 3 years ago

Yes that implementation sounds good to me :+1:

Thanks again!