friebetill / obsidian-deepl

DeepL for Obsidian.
MIT License
46 stars 6 forks source link

Enhancement: Hotkey addition, and new line. #10

Open arcticpinecone opened 3 months ago

arcticpinecone commented 3 months ago

Thank you for the useful Obsidian plugin! 🙏🙇‍♂️

I'd like to propose an enhancement to the translation hotkey options to improve workflows.

Currently, the plugin offers these hotkey options for translation:

Proposed Addition:

This would use the To language preset from the plugin's Language settings without prompting for language selection each time, simplifying the workflow.

The existing To language and append to selection option is useful, and I suggest maintaining it, possibly with an added setting for inserting a newline automatically.

Example Use Case: This change would facilitate language comparison in a stacked format: "Tässä on näyteteksti kääntämiseksi haluamalleni kielelle." "Here is a sample text to convert to my preferred language."

Currently, without a newline, the translation appends directly, making it less readable: "Tässä on näyteteksti kääntämiseksi haluamalleni kielelle." "Here is a sample text to translate into the language of my choice."

This enhancement would greatly benefit users who frequently compare translated texts.

arcticpinecone commented 3 months ago

Hello again!

I am a curious and driven person, so I learned how to branch some code from a fork, then had to figure out how to compile the code (I'm a Python novice), and then push this and make my first ever pull request.

In any case, putting the built main.js in the .obsidian\plugins\deepl folder allowed me to test this really easily, and I confirmed it's all functional and working. I made an additional commit to add the newline function also to the Translate selection: To language and append to selection feature.

I sincerely appreciate your plugin, and I wanted to give back with this feature. I hope you find it satisfactory.