friedPotat0 / Spam-Scores

Thunderbird add-on to display spam scores according to mail headers. Supports spam/ham score headers of Rspamd and SpamAssassin. The add-on adds a column with the overall spam score to the mail list view and shows details of any matched spam/ham rule.
https://addons.thunderbird.net/de/thunderbird/addon/spam-scores/
Other
42 stars 6 forks source link

Add support for X-Spam-Report header added by Exim #12

Closed fuxii closed 3 years ago

fuxii commented 3 years ago

Would it be possible to add support for headers added by Exim? Since I'm not using rspamd in milter mode. Especially the detailed view with the used symbols would be the most interesting for me.

Example headers:

X-Spam-Status: No, score=1.9
X-Spam-Score: 1.9
X-Spam-Bar: +
X-Spam-Report: Action: no action
 Symbol: HAS_REPLYTO(0.00)
 Symbol: BAYES_SPAM(0.02)
 Symbol: FORWARDED(0.00)
 Symbol: IP_REPUTATION_HAM(-0.00)
 Symbol: R_SPF_ALLOW(0.00)
 Symbol: TO_DN_NONE(0.00)
 Symbol: DKIM_TRACE(0.00)
 Symbol: HAS_X_PRIO_THREE(0.00)
 Symbol: SUBJECT_ENDS_EXCLAIM(0.00)
 Symbol: FORGED_SENDER(0.00)
 Symbol: MIME_TRACE(0.00)
 Symbol: RCVD_TLS_LAST(0.00)
 Symbol: ASN(0.00)
 Symbol: FROM_NEQ_ENVFROM(0.00)
 Symbol: ARC_NA(0.00)
 Symbol: R_DKIM_ALLOW(0.00)
 Symbol: FROM_HAS_DN(0.00)
 Symbol: FORGED_SENDER_FORWARDING(0.00)
 Symbol: TO_MATCH_ENVRCPT_ALL(0.00)
 Symbol: URIBL_GREY(1.50)
 Symbol: REPLYTO_DOM_NEQ_FROM_DOM(0.00)
 Symbol: PREVIOUSLY_DELIVERED(0.00)
 Symbol: FORGED_SENDER_VERP_SRS(0.00)
 Symbol: RCPT_COUNT_ONE(0.00)
 Symbol: BAD_REP_POLICIES(0.10)
 Symbol: MANY_INVISIBLE_PARTS(0.05)
 Symbol: DMARC_NA(0.00)
 Symbol: MIME_HTML_ONLY(0.20)
 Symbol: RWL_MAILSPIKE_POSSIBLE(0.00)
 Symbol: RCVD_COUNT_TWO(0.00)
 Message-ID: xxx@xxx.net
X-Spam-Flag: NO
friedPotat0 commented 3 years ago

Thanks for reporting! I've rewritten the symbol parsing in general now to support even prefixed score notations and limit the score parsing to the header itself. It should now support the header you provided.

You can test the new version before it will be released by follwing the instructions on the last paragraph of the installation section in the readme (https://github.com/friedPotat0/Spam-Scores#installation). Branch to use: "change-symbol-parsing"

fuxii commented 3 years ago

Thanks for the fast reply. I tried your "change-symbol-parsing" branch and it works as expected now:

spam-headers

Thanks again!

friedPotat0 commented 3 years ago

The new version 1.1.5 is now released in the official Thunderbird's add-on store. I suggest you to uninstall the custom version you installed from the change-symbol-parsing branch and install it directly from the official page or the latest release of this GitHub repository (https://github.com/friedPotat0/Spam-Scores/releases/tag/1.1.5) in order to receive future updates.

Best regards and have a nice weekend.

fuxii commented 3 years ago

Thanks. My Thunderbird automatically updated to 1.1.5 from the repo. Thanks again for your fast resolution and effort!

friedPotat0 commented 3 years ago

Oh, ok. That's good to know. Thanks for the feedback.

fuxii commented 3 years ago

I have to add here, that I clicked on "check for updates" on the addons page in Thunderbird. But then the addon was automatically updated ;)