friedPotat0 / Spam-Scores

Thunderbird add-on to display spam scores according to mail headers. Supports spam/ham score headers of Rspamd and SpamAssassin. The add-on adds a column with the overall spam score to the mail list view and shows details of any matched spam/ham rule.
https://addons.thunderbird.net/de/thunderbird/addon/spam-scores/
Other
42 stars 6 forks source link

Please replace .png with .svg icons #19

Closed sphh closed 3 years ago

sphh commented 3 years ago

Is your feature request related to a problem? Please describe. On hi-res screens, the icons indicating the spam score becomes somewhat fuzzy: Screenshot from 2021-04-01 19-54-59 Please compare it to the star, which is crisp.

Describe the solution you'd like Replacing the icon with a .svg file should keep scaling problems at bay.

Additional context The Show InOut add-on had a similar problem which was sorted by replacing the icon with a .svg file.

friedPotat0 commented 3 years ago

That's right. I noticed that too and would have liked to solve it with proper vector graphics. However, I can't find any documentation on the integration of SVGs in custom columns integrated in MailExtensions. I also took a look at the latest version of the Show InOut add-on mentioned above, but it seems like they use PNG files for the column icons, too. Maybe I can slightly increase the resolution of the current PNGs.

I don't know why the documentation for these MailExtensions is so weak. You can hardly find any information about specific problems and have to collect everything from other add-ons.

I will definitely take a closer look at the resolution problem of the icons.

sphh commented 3 years ago

So Günter has not published it yet.

Here is the adapted showInOUt.css file:

/* ..... inout column ..... */

treecol.inoutColumnHeader {
  list-style-image: url("correspondents-col.svg");
}

/* Using indicators */
treechildren::-moz-tree-image(sio_inoutCol, out) {
  list-style-image: url("out.svg");
}
treechildren::-moz-tree-image(sio_inoutCol, to_me) {
  list-style-image: url("to_me.svg");
}
treechildren::-moz-tree-image(sio_inoutCol, to_others) {
  list-style-image: url("to_others.svg");
}
treechildren::-moz-tree-image(sio_inoutCol, to_list) {
  list-style-image: url("to_list.svg");
}
/* end indicators*/
/* revert to old icons:
treechildren::-moz-tree-image(sio_inoutCol) {
  list-style-image: url("skin/inout.png");
}
*/

and the .svg is a 16×16pixel .svg file. Does this help?

friedPotat0 commented 3 years ago

That was the missing part. Thanks for the hint. It will be included in the next version. I will check if I can fix some of the other issues before release.

sphh commented 3 years ago

All credit is due to Günter from the ShowInOut add-on, because he told me, when I "complained" about the fuzzy icons in his add-on.

sphh commented 3 years ago

BTW nice, crisp and clear icons! :+1:

sphh commented 3 years ago

Thanks!