Fix capitalization for class names

friedererdmann / pymxs_stubs

Stubs and stub generator for PyMXS

MIT License

35 stars 5 forks source link

Fix capitalization for class names #1

Closed friedererdmann closed 2 years ago

friedererdmann commented 2 years ago

Currently inheritance can break between classes as classes might be capitalized or not. This leads to classes inheriting from Color but the class color was not capitalized. By default all class names should be CamelCased, also to avoid clashes with built-ins (like set and Set).

friedererdmann commented 2 years ago

Also: property names need to be lower case to avoid name clashes with class names.

friedererdmann commented 2 years ago

Fixed in 0de562afe81eb2849f06898e8e49d18e28d35418

Classes are now CamelCase or at least Titlecase (upper case letters always win, so favoring CamelCase)
Methods are now lowercase
Attributes are now UPPERCASE
- A fair amount of attributes clashed with python keywords if they were lowercase
- Easier to distinguish methods and attributes at a glance

Might follow up with a specialty rule to change cases where methods might clash with keywords (currently they are removed, but might rename them to avoid naming clash instead).