⚡[FEAT] Use newly deployed contracts with clarity-bitcoin-lib-v5

friedger / stacks-swaps

Swapping BTC and tokens on Stacks chain

GNU General Public License v3.0

16 stars 15 forks source link

⚡[FEAT] Use newly deployed contracts with clarity-bitcoin-lib-v5 #11

Open friedger opened 6 months ago

friedger commented 6 months ago

Is your feature request related to a problem? Please describe. clarity-bitcoin-lib-v5 was deployed on mainnet. We should use the new contracts from https://github.com/friedger/clarity-catamaranswaps

Describe the solution you'd like

change the contract addresses
remove the warnings about flash blocks

Additional context https://github.com/friedger/clarity-catamaranswaps/issues/3

Oyeins-GUI commented 6 months ago

Is your feature request related to a problem? Please describe. clarity-bitcoin-lib-v5 was deployed on mainnet. We should use the new contracts from https://github.com/friedger/clarity-catamaranswaps

Describe the solution you'd like

change the contract addresses

remove the warnings about flash blocks

Additional context friedger/clarity-catamaranswaps#3

I don't quite understand the issue here, maybe you could shed more light on it

friedger commented 6 months ago

Currently, the UI uses btc-stx-swap (v1). I'll deploy btc-stx-swap-v2 and the UI should then use the new contract id.

In addition, the new contact removes some limitations of the catamaran swap. Therefore, the UI should be adapted, basically, remove some lines of code.

friedger commented 6 months ago

There are also new UIs for catamaran swap:

https://github.com/smartcoder0305/cantamaranswap
https://github.com/rk1129/cantamaranswap However, they do not work yet with the smart contract.

If you want to investigate, that would be cool as well.

Oyeins-GUI commented 6 months ago

Currently, the UI uses btc-stx-swap (v1). I'll deploy btc-stx-swap-v2 and the UI should then use the new contract id.

In addition, the new contact removes some limitations of the catamaran swap. Therefore, the UI should be adapted, basically, remove some lines of code.

Still trying to find my way around in the code

Oyeins-GUI commented 6 months ago

Currently, the UI uses btc-stx-swap (v1). I'll deploy btc-stx-swap-v2 and the UI should then use the new contract id.

In addition, the new contact removes some limitations of the catamaran swap. Therefore, the UI should be adapted, basically, remove some lines of code.

Oh! Gotten it now

Have you deployed it already?

friedger commented 6 months ago

This is solved. Contract not yet deployed. PR not yet merged.