search

friedhof / sportchef

Sports Competition Management Software
https://www.sportchef.ch/
GNU Affero General Public License v3.0
15 stars 14 forks source link

#258 Adding sportchef-ajax to wrap all ajax requests with an auth token #281

Closed wheresvic closed 8 years ago

wheresvic commented 8 years ago

If any exists :)

This change is Reviewable

madmas commented 8 years ago

👍 looks good

McPringle commented 8 years ago

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions.

_src/main/resources/webapp/sportchef_components/sportchef-ajax/sportchef-ajax.html, line 27 [r1] (raw file):_


    <script>
        // register a new element called sportchef-events

Should be "sportchef-ajax" instead of "sportchef-events", I think… ;-)

_src/main/resources/webapp/sportchef_components/sportchef-ajax/sportchef-ajax.html, line 54 [r1] (raw file):_

                contentType: {
                    type: String,
                    value: null // "application/json" for auto json encoding

It would be great to specify "application/json" as default value instead of "null"

Comments from Reviewable

wheresvic commented 8 years ago

Done with required changes :)

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 80.848% when pulling 3035b99654f8ab5747ba20733dfd58630b1c61eb on victorparmar:develop into df2e634f8c0546d620800719448a33099bf34b3e on McPringle:develop.

McPringle commented 8 years ago
:lgtm:

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

_Comments from Reviewable_

McPringle commented 8 years ago

Reviewed 3 of 4 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Comments from Reviewable