Closed wheresvic closed 8 years ago
👍 looks good
Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions.
_src/main/resources/webapp/sportchef_components/sportchef-ajax/sportchef-ajax.html, line 27 [r1] (raw file):_
<script> // register a new element called sportchef-events
Should be "sportchef-ajax" instead of "sportchef-events", I think… ;-)
_src/main/resources/webapp/sportchef_components/sportchef-ajax/sportchef-ajax.html, line 54 [r1] (raw file):_
contentType: { type: String, value: null // "application/json" for auto json encoding
It would be great to specify "application/json" as default value instead of "null"
Comments from Reviewable
Done with required changes :)
Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.
_Comments from Reviewable_
Reviewed 3 of 4 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.
Comments from Reviewable
If any exists :)
This change is![Reviewable](https://reviewable.io/review_button.svg)