CJK charaters are being rendered as squares

friedow / centerpiece

Your trusty omnibox search.

MIT License

174 stars 6 forks source link

CJK charaters are being rendered as squares #128

Closed Guanran928 closed 2 months ago

Guanran928 commented 2 months ago

I'm using Source Han Sans VF as CJK font, does this mean centerpiece don't support font fallback?

Guanran928 commented 2 months ago

https://github.com/friedow/centerpiece/issues/103#issuecomment-2021289280, oops, didn't search with the right keyword

Will close when https://github.com/friedow/centerpiece/pull/81 is merged

friedow commented 2 months ago

I've enabled font fallback in #131. Feel free to test that branch and leave a review whether this works for you :).

Guanran928 commented 2 months ago

Hmm, I still cant see Chinese in window titles

❯ nix run github:friedow/centerpiece/pull/131/head -- --version
centerpiece 1.0.0 - 2024-04-15 - 7318ea3

Guanran928 commented 2 months ago

Oh, you can see CJK & emojis in the search box (weirdly, also in 0.8.0 from nixpkgs), but not in the selector.

friedow commented 2 months ago

That's weird. I've ran the same command:

> nix run github:friedow/centerpiece/pull/131/head -- --version
centerpiece 1.0.0 - 2024-04-15 - 7318ea3

> nix run github:friedow/centerpiece/pull/131/head

The title of this website: https://www.archchinese.com/ is displayed correctly in the brave history plugin:

Can you check whether the characters work in the brave history plugin for you?

(FYI: The version in nixpkgs had advanced text shaping in the input box but not in the entry list. This is why it looks that way ;))

Guanran928 commented 2 months ago

Yeah, it's working fine now. I guess maybe I ran the wrong version last time?

friedow commented 2 months ago

Oh perfect, I'm really happy to hear that :). Will merge the Bugfix branch then!