search

friedrichknuth / covid_dashboard

MIT License
4 stars 2 forks source link

move env to binder branch #1

Closed rsignell-usgs closed 4 years ago

rsignell-usgs commented 4 years ago

If the environment is moved to a binder branch, you can run on binder, but then modify notebooks without rebuilding the image, as described here. I'll submit a PR shortly.

rsignell-usgs commented 4 years ago

Hmm, actually, I guess I can't submit a PR to a binder branch if there is no binder branch yet?

tjcrone commented 4 years ago

Thanks for this update @rsignell-usgs. This is very helpful!

rsignell-usgs commented 4 years ago

Just a note that if we introduce code or notebooks that require additional libraries, we should add them to the environment.yaml files in both the master and binder branches.

The environment.yaml file in the master branch is for folks who want to recreate the environment locally.

The environment.yaml file in the binder branch is for running on binder. As long at that environment doesn't change and binder doesn't rebuild the docker image!

Binder pulls the code and notebook from master using git after it loads the environment, so we can modify those all we want and use the same image on binder.

benholtzman commented 4 years ago

y'all seen this?: https://covidtracking.com/data/

On Sat, Mar 14, 2020 at 5:55 PM Rich Signell notifications@github.com wrote:

Just a note that if we introduce code or notebooks that require additional libraries, we should add them to the environment.yaml files in both the master and binder branches.

The environment.yaml file in the master branch is for folks who want to recreate the environment locally.

The environment.yaml file in the binder branch is for running on binder. As long at that environment doesn't change and binder doesn't rebuild the docker image!

Binder pulls the code and notebook from master using git after it loads the environment, so we can modify those all we want and use the same image on binder.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/friedrichknuth/covid_dashboard/issues/1#issuecomment-599139866, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCSZTYDWSLW2EETPYRXEVTRHP4N7ANCNFSM4LJSBTVA .

tjcrone commented 4 years ago

This is cool @benholtzman! This issue is closed though, and related to something else. Can I ask you to start another issue regarding data sources? This is something that we definitely need to discuss. We started a discussion at #5, but it really needs its own issue. Thanks!