friedrith / node-wifi

📶 NodeJS tool to manage wifi (connections, scans)
MIT License
396 stars 161 forks source link

fix(windows): connect network for non-admin users #164

Closed geetanshjain closed 2 years ago

geetanshjain commented 2 years ago

Description

While connecting to a network in windows by a non-admin user, the connection fails if the project/package-workspace is under some restricted location (Ex: Program Files) because the nodeWifiConnect.xml is created is not getting created due to permission issues. Changed the location of nodeWifiConnect.xml to be created in a temporary directory (C:\Users\AppData\Local\Temp) so that work flow is uninterrupted for non-admin user also.

Motivation and Context

This change is required as all window users (Admin and Non-Admin) should be able to connect to the network.

159

Usage examples

How Has This Been Tested?

After the required changes are done, we tried to connect to the network in a non-admin user machine, which works as expected.

Types of changes

friedrith commented 2 years ago

Hi, give me 2 days to process this PR.

friedrith commented 2 years ago

Perfect 👌

friedrith commented 1 year ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.