friedrith / node-wifi

📶 NodeJS tool to manage wifi (connections, scans)
MIT License
397 stars 161 forks source link

NetworkUtils.frequencyFromChannel function is not accurate. #17

Closed obermillerk closed 6 years ago

obermillerk commented 7 years ago

See this wikipedia article.

There are channels that you don't include and also different frequencies associated with the same channel on different bands (though it looks like they're mostly inconsequential since they aren't allowed in most places?). I should note I encountered this problem since the network I use (5GHz) gave me a channel of 149 on Windows.

friedrith commented 7 years ago

You are totally right. For now, it uses European norms. You are totally free to propose a Pull request to manage these other places. So, it could be useful to add a settings defining the current place.

Otherwise, I think I will do it during the next months.

obermillerk commented 7 years ago

The frequency is not particularly important to me, so I think I'll let you handle it how you see fit. Just wanted to let you know.

friedrith commented 7 years ago

Ok.

friedrith commented 6 years ago

Hi, I have pushed a new version available on master branch (but not on npm yet) which improves the way to manage frequencies. It manages much more frequencies and add channels to the result (just in case the frequencies are still wrong for you). Can you check if it is ok for you ?

friedrith commented 6 years ago

The new version has been published on npm so do not hesitate to try it and tell me it is ok for you.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.