search

friedrith / node-wifi

📶 NodeJS tool to manage wifi (connections, scans)
MIT License
397 stars 161 forks source link

getCurrentConnections MAC Fix #29

Closed felixgalindo closed 6 years ago

felixgalindo commented 6 years ago

Fixed issue where getCurrentConnections would not work on MAC

friedrith commented 6 years ago

Thx for the PL. Can you explain what is the difference ? With the indentation change, it is quite hardto understand the difference the previous code and the new one ?

Moreover can you make the PL for the dev branch as requested in the contributing file ?

felixgalindo commented 6 years ago

Changed "function getCurrentConnections(config, callback)" to function "getCurrentConnections(callback)". Didn't see why config was needed. Was causing issues with the callback never getting called back. Sorry about the indentation, my file editor automatically formats it.

friedrith commented 6 years ago

This PR doesn't respect current contribution norms. And it seems to be duplicated with PR #32 .

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.