friedrith / node-wifi

📶 NodeJS tool to manage wifi (connections, scans)
MIT License
397 stars 161 forks source link

correctly return error if network is not found #38

Closed ocjojo closed 5 years ago

ocjojo commented 6 years ago

When trying to connect to a wifi that was not there in the first place. The method returned a success instead of error.

friedrith commented 6 years ago

Ok I look at it this week and I merge it just after.

ocjojo commented 6 years ago

Let me know if you have any questions or improvements.

ocjojo commented 6 years ago

Did you get a chance to take a look yet?

On a sidenote: I saw that you are looking for maintainers? Can you provide me some details? I would be interested.

friedrith commented 6 years ago

Hi, sorry for the delay but because of my work travels I was not access to my personal computers. Everything is good but I merged it on the development branch for now. I prefer the master branch to be exactly the branch deployed on npm. I will publish a new version with next week.

About the maintainers: this project has been created with my company but now I am the only maintainer and I would love to have help because it takes a lot of time that I don't have:

So if you want to maintain this project with me, you are welcome!

friedrith commented 6 years ago

I will close this PL when I will publish your change on npm

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.