search

friedrith / node-wifi

📶 NodeJS tool to manage wifi (connections, scans)
MIT License
397 stars 161 forks source link

Fixed Windows netsh missing argument problem #44

Closed rodrigogs closed 5 years ago

rodrigogs commented 6 years ago

I was having problems to connect to a network using my 2nd wi-fi interface on Windows 10.

I executed the command manualy and the error seemed to be a missing argument. Than noticed that passing the interface="intf" argument, the command works. I think it's because I have more than one interfaces connected to my pc, so I have to tell netsh what interface I want to use.

Already tested this PR in my PC, and it's working. I don't think this extra argument could impact other behaviours.

friedrith commented 6 years ago

Hi, Your PL was quite good but I changed it a little just to set the interface argument of netsh only when the option iface is set. So it the interface is not set by the user in the CLI, netsh doesn't have the interface argument and so choose the best.

I pushed your commit and mine on the top on the dev branch. Can you check if it correct your bug?

rodrigogs commented 6 years ago

I'm traveling without a computer. Tomorrow I'll test it ;)

friedrith commented 6 years ago

Ok no problem. Take your time. That's why happened to me but for more than 3 weeks ^^. That's why I took so much time to answer.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.