search

friedrith / node-wifi

📶 NodeJS tool to manage wifi (connections, scans)
MIT License
395 stars 161 forks source link

Fixes linux scan with specified iface and not English words in ssid names #46

Closed fractalzombie closed 5 years ago

friedrith commented 6 years ago

Hi, Sorry for the delay. I am so sorry but while accepting the previous pull requests before your own pull requests I corrected your problem. However, I kept in mind the following code and I included it:

if (config.iface) {
     lines.shift()
}

I didn't know that the first line of the result was the name of the interface when the iface option is set. Whatever, it is more safe to excep the first line when the iface name is present. Thank you for this tricks I didn't handle before.

You also add a new result called signal. An other user was asking for a result called quality with the same value: the signal level but in percentage. Since I accepted its PR first, the accepted name is quality but it doesn't change a lot of thing.

Thank you a lot for your propositions. They really improve the quality of code. All my corrections are in the dev branch for now. So do not hesitate to try it and tell me if something is not correct.

manast commented 5 years ago

Seems like a safe merge this one too :)

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.