search

friedrith / node-wifi

📶 NodeJS tool to manage wifi (connections, scans)
MIT License
395 stars 161 forks source link

fix child_process.exec options format #56

Closed dinuchiriac closed 5 years ago

dinuchiriac commented 5 years ago

The env should be a property of an options Object and should not be passed directly. By sending it directly it will clash with other libraries that are trying to override exec Options. In my case, this is pkg library, see: https://github.com/zeit/pkg/blob/master/prelude/bootstrap.js#L1336 See child_process.exec docs: https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback

friedrith commented 5 years ago

Thx for the PR, I resolve conflicts and I merge it after.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.