Closed SteinRobert closed 5 years ago
Your code seems me very clear. I thinkt it would be nice to do it for windows too. Besides, you should fix prettier issue. You can do it using command npm run prettier:fix
@friedrith just updated the branch with the adaptions for Windows and the fixes for prettier. Besides - I also just tested the adaptions for Windows - everything went well, except you should probably merge this PR: https://github.com/friedrith/node-wifi/pull/80 The adaption is necessary to connect to a wifi on Windows.
Oups thank you for the reminder for #80 I totally forgot to merge it. But unfortunately when I merged #80, conflicts happened with your pull request. Can you update it ?
I appreciate a lot your work and your effort. Thx !
Just updated the branch. 😄
Great let's merge it !
It will be integrated in next release that should be published today or tomorrow.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Fixes CLI command injection vulnerability. The fix currently only contains changes for MacOS and Linux. If you think it's looking good I can help make the adaptions for Windows as well.
Motivation and Context
Make the package more safe to be installed and use.
Usage examples
How Has This Been Tested?
Manual tests on Linux and MacOS.
Types of changes