search

friendica / dir

Friendica Global Directory
14 stars 12 forks source link

Profiles with censored=1 should not be updated / unblocked by cron_sync.php #47

Closed Quix0r closed 6 years ago

Quix0r commented 6 years ago

If cron_sync.php runs, all accounts got unblocked. This should not happen as this makes anti-spam measurements unpractical.

MrPetovan commented 6 years ago

Where is censored set in the first place? What does it affect? Just display in the public directory?

Quix0r commented 6 years ago

Table profile, it will effectively hide the profile from the list.

MrPetovan commented 6 years ago

Ok thanks.

tobiasd commented 6 years ago

Anyone could flag a profile in the directory, for being nsfw or dead, and then the directory admin could delete/censor those profiles from the directory node.

MrPetovan commented 6 years ago

Can you flag them in the current directory?

Quix0r commented 6 years ago

I mean the censored flag got reset after sync ran.

Quix0r commented 6 years ago

And where is the flag button?

MrPetovan commented 6 years ago

You tell me, I've never seen the flag button.

tobiasd commented 6 years ago

I guess somebody(TM) removed it for aesthetics and hopefully planned to include it back later on but then lost track of the issue. It was a simple interface, but at least one could report profiles and the admin of the directory could review those reports.

MrPetovan commented 6 years ago

I've seen this in the code, with admin users able to log in to the directory and review the flagged accounts, but it seemed like old code.

tobiasd commented 6 years ago

It was actively used code till the layout switch. Every time I logged into the old directory there were some accounts flagged for review.

MrPetovan commented 6 years ago

Since I can't log in into the new directory, there aren't any flagged accounts anymore!

tobiasd commented 6 years ago

Which is not really a satisfactory situation for the vanishing of a useful and used function TBH But I'll close my eyes and don't see any SPAM until the feature comes back.

MrPetovan commented 6 years ago

That's the spirit!

MrPetovan commented 6 years ago

The next version of the directory uses a censored flag at the profile and the server level, which hides all the profiles registered on that server, as well as preventing future polling. It still is a manual task in the DB though. I may add a console task for this.

Quix0r commented 6 years ago

Thank you for your work. :-)