used to be entirely highlighted. However, after working on issue 152 mentioned above, with the latest version using stack_data, they are no longer highlighted. This is ok for friendly_traceback, but with the coloured highlighting provided by friendly, it makes sense to highlight them.
Tasks:
[x] Upload a new version to Pypi that uses a specific version of friendly_traceback
After friendly_traceback has been updated
[x] Make friendly compatible with this newest version
[x] Upload a new version to Pypi
[x] Improve highlighting when triple-quote text is present
[x] Make sure that single line statement, such as raise LookupError("Fake message") mentioned above, would still be highlighted. The key here is to look for a line indicator, -->, with no corresponding ^ markers. Edit With the new hihglighting of the line number itself, it does not seem necessary to highlight the entire text; in fact, it would be less attractive to do so.
[x] Use Rich's addition for "partial highlights" (need a reference here) to replace my current custom code for background highlighting. My revised version likely works better as the contrast is guaranteed.
See https://github.com/friendly-traceback/friendly-traceback/issues/152
Note: some statements like
used to be entirely highlighted. However, after working on issue 152 mentioned above, with the latest version using
stack_data
, they are no longer highlighted. This is ok forfriendly_traceback
, but with the coloured highlighting provided byfriendly
, it makes sense to highlight them.Tasks:
friendly_traceback
Afterfriendly_traceback
has been updatedfriendly
compatible with this newest versionraise LookupError("Fake message")
mentioned above, would still be highlighted. The key here is to look for a line indicator,-->
, with no corresponding^
markers. Edit With the new hihglighting of the line number itself, it does not seem necessary to highlight the entire text; in fact, it would be less attractive to do so.UseMy revised version likely works better as the contrast is guaranteed.Rich
's addition for "partial highlights" (need a reference here) to replace my current custom code for background highlighting.