search

friendly-traceback / friendly

Friendly-traceback's version used in most situations
https://friendly-traceback.github.io/docs/index.html
MIT License
40 stars 5 forks source link

friendly crashes with six < 1.12 #47

Closed mardukbp closed 1 year ago

mardukbp commented 1 year ago

With six 1.11 friendly crashes with

Fatal error - aborting module 'six' has no attribute 'ensure_text'
Please report this issue.

Please add six >= 1.12 to the runtime requirements.

aroberge commented 1 year ago

Thanks for the report. I need to figure out where 'six' is needed exactly, as it might be needed as a requirement for friendly_traceback also.

aroberge commented 1 year ago

six >=1.11 is needed to prevent bugs.

six >=1.16 is needed to prevent the following warning from being displayed.

`ImportWarning`: _SixMetaPathImporter.find_spec() not found; falling back to find_module()

Edit: six is needed by https://github.com/gristlabs/asttokens

aroberge commented 1 year ago

Thanks again for reporting this issue. It has been addressed by adding the requirement to friendly_traceback and requiring friendly to use the latest version of friendly_traceback.

mardukbp commented 1 year ago

and requiring friendly to use the latest version of friendly_traceback

That's great! I wanted to suggest that too.