A assortment of additions

friendly / matlib

Matrix Functions for Teaching and Learning Linear Algebra and Multivariate Statistics

http://friendly.github.io/matlib/

65 stars 16 forks source link

A assortment of additions #5

Closed philchalmers closed 8 years ago

philchalmers commented 8 years ago

Hi Michael,

These are just some additions that I made to the package, nothing ground-breaking. I've kept the commits distinct so you can cherry pick/criticise them as you please. Here's what I've added:

example to gsorth
improved the verbose output from gaussianElimination (e.g., returns invisible object rather than printing the same object 2x), prints the initial form, and adds a newline space to better distinguish steps
added a latex logical argument to gaussianElimination and showEqn to construct output suitable for LaTeX documents

Let me know if you have any questions. Cheers.

friendly commented 8 years ago

These seem to be useful additions. We hadn't thought about latex output, but that is a nice extension.

philchalmers commented 8 years ago

I thought so as well. There probably could be another function written to do this more generally (akin to xtable::xtableMatharray()) which also accepts a fraction argument. Unfortunately, xtable drops the fractions when generating the TeX code and reverts to decimals, so it has to be coerced to a character object first. Would be happy to write a wrapper like this.

john-d-fox commented 8 years ago

Hi Phil,

Thanks for your interest in this -- it's helpful because of course I originally wrote gaussianElimination() to be transparent.

Best, John

-----Original Message----- From: Phil Chalmers [mailto:notifications@github.com] Sent: March 14, 2016 12:09 PM To: friendly/matlib matlib@noreply.github.com Subject: Re: [matlib] A assortment of additions (#5)

I thought so as well. There probably could be another function written to do this more generally (akin to xtable::xtableMatharray()) which also accepts a fraction argument. Unfortunately, xtable drops the fractions when generating the TeX code and reverts to decimals, so it has to be coerced to a character object first. Would be happy to write a wrapper like this.

— Reply to this email directly or view it on GitHub https://github.com/friendly/matlib/pull/5#issuecomment-196387410 . https://github.com/notifications/beacon/ANcgQghtBtEacNLGlBjkit10XFIcon 7sks5ptYgYgaJpZM4Hvp8W.gif

friendly commented 8 years ago

Let's wait until John & I update our versions from these commits to the repo and do some testing. We are happy for your participation in this project.